feat(gold_standard): add traitFromSourceMappedId to schema #924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
This PR adds the EFO ID to the gold standard so that we can split the training set by EFO/Gene during cross validation.
The change in the schema doesnt have implication in FE/BE as discussed.
Bare in mind this will create some explosion in the gold standard.
🛠 What does this PR implement
🙈 Missing
A following PR will make more thorough changes in the schema of the gold standard, and in the code to accommodate this dataset to the definition of a effector gene list.
The new field is set to nullable = True for the time being, so that tests don't complain. This field should be mandatory in the future.
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?