-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add studyType
to StudyLocus
and Colocalisation
(and StudyLocusOverlap
)
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yLocusOverlap schemas
…e and rightStudyType
…e and rightStudyType
… function def and calls
Closed
7 tasks
DSuveges
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All really makes sense. Great job tracking down all the consequences of the change! I hope you found the breaking tests useful.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
studyType
is needed to:StudyLocus
) andColocalisation
results at the API levelStudyLocus
are compared inColocalisation
, derived from theStudyLocusOverlaps
See #3444 for more info.
🛠 What does this PR implement
studyType
is added toStudyLocus
.rightStudyType
is added toStudyLocusOverlap
, andColocalisation
.Changes were made to the schema, creation of these objects and tests involving these objects.
Code is updated in cases where getting the
studyType
/rightStudyType
from theStudyIndex
isn't required anymore.🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?