Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add studyType to StudyLocus and Colocalisation (and StudyLocusOverlap) #782

Merged
merged 20 commits into from
Sep 24, 2024

Conversation

vivienho
Copy link
Contributor

@vivienho vivienho commented Sep 23, 2024

✨ Context

studyType is needed to:

  • Filter credible sets (StudyLocus) and Colocalisation results at the API level
  • Influence the logic of which StudyLocus are compared in Colocalisation, derived from the StudyLocusOverlaps

See #3444 for more info.

🛠 What does this PR implement

studyType is added to StudyLocus.
rightStudyType is added toStudyLocusOverlap, and Colocalisation.

Changes were made to the schema, creation of these objects and tests involving these objects.
Code is updated in cases where getting the studyType/rightStudyType from the StudyIndex isn't required anymore.

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@vivienho vivienho marked this pull request as ready for review September 24, 2024 09:59
@vivienho vivienho requested a review from DSuveges September 24, 2024 10:00
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All really makes sense. Great job tracking down all the consequences of the change! I hope you found the breaking tests useful.

@DSuveges DSuveges merged commit dcacaf7 into dev Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding studyType to StudyLocus and Colocalisation (StudyLocusOverlaps)
2 participants