Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding finemapping method to studylocusid hash #744

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

Daniel-Considine
Copy link
Contributor

@Daniel-Considine Daniel-Considine commented Sep 2, 2024

✨ Context

Currently studyLocusId column is generated from studyId and variantId. This isn't a unique identifier for cases where the same top variant from the same study is fine-mapped with multiple methods (pics. susie, SuSiE-inf)

🛠 What does this PR implement

Includes the finemappingMethod column into the hash generation

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

Copy link
Contributor

@project-defiant project-defiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

@github-actions github-actions bot removed the Method label Sep 3, 2024
@project-defiant
Copy link
Contributor

@Daniel-Considine can you just add the same logic to the of the StudyLocusId recalculation with finemappingMethod column to the pics step?

@github-actions github-actions bot added the Method label Sep 3, 2024
@project-defiant
Copy link
Contributor

@DSuveges @Daniel-Considine let's keep the updated cs StudyLocusId as @Daniel-Considine developed it for now as I need it for the downstream testing of the credible set without rerunning the dags. In the meantime I will prepare the version with md5 hash instead.

@project-defiant project-defiant merged commit 15a058e into dev Sep 9, 2024
4 checks passed
@project-defiant project-defiant deleted the dc_studylocusid_rehash branch September 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants