-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding finemapping method to studylocusid hash #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments.
@Daniel-Considine can you just add the same logic to the of the gentropy/src/gentropy/method/pics.py Line 256 in bb8558c
|
@DSuveges @Daniel-Considine let's keep the updated cs StudyLocusId as @Daniel-Considine developed it for now as I need it for the downstream testing of the credible set without rerunning the dags. In the meantime I will prepare the version with md5 hash instead. |
✨ Context
Currently studyLocusId column is generated from studyId and variantId. This isn't a unique identifier for cases where the same top variant from the same study is fine-mapped with multiple methods (pics. susie, SuSiE-inf)
🛠 What does this PR implement
Includes the finemappingMethod column into the hash generation
🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?