Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(finemapping): finngen harmonisation (schema and orchestration) #489

Merged
merged 10 commits into from
Feb 22, 2024

Conversation

xyg123
Copy link
Contributor

@xyg123 xyg123 commented Feb 14, 2024

Correct setting for airflow config, and corrected raw input schema for finngen susie outputs.

@xyg123 xyg123 requested a review from d0choa February 14, 2024 12:01
Copy link
Collaborator

@d0choa d0choa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

src/airflow/dags/common_airflow.py Outdated Show resolved Hide resolved
src/airflow/dags/finngen_preprocess.py Outdated Show resolved Hide resolved
src/gentropy/config.py Outdated Show resolved Hide resolved
@d0choa d0choa changed the title fix: Finngen fm schema fix(finemapping): finngen harmonisation (schema and orchestration) Feb 21, 2024
Copy link
Collaborator

@d0choa d0choa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. Feel free to merge when you are ready @xyg123
We should see if everything works smoothly with the help of @Daniel-Considine

@xyg123 xyg123 merged commit b2abe3f into dev Feb 22, 2024
3 checks passed
@xyg123 xyg123 deleted the finngen_fm_schema branch March 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants