Skip processing partial message (SOHU-Co#1051)

opentable · May 24, 2019 · cf98ca8 · cf98ca8
1 parent a231ccf
commit cf98ca8
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/protocol/protocol.js b/lib/protocol/protocol.js
@@ -168,12 +168,13 @@ function decodeMessageSet (topic, partition, messageSet, cb, maxTickMessages, hi
   const messageSetSize = messageSet.length;
   while (messageSet.length > 0) {
     var cur = 8 + 4 + 4 + 1 + 1 + 4 + 4;
+    var partial = false;
     Binary.parse(messageSet)
       .word64bs('offset')
       .word32bs('messageSize')
       .tap(function (vars) {
         if (vars.messageSize > messageSet.length - 12) {
-          vars.partial = true;
+          partial = true;
         }
       })
       .word32bs('crc')
@@ -214,7 +215,7 @@ function decodeMessageSet (topic, partition, messageSet, cb, maxTickMessages, hi
           return;
         }
 
-        if (!vars.partial && vars.offset !== null) {
+        if (!partial && vars.offset !== null) {
           messageCount++;
           set.push(vars.offset);
           if (!cb) return;
@@ -241,6 +242,8 @@ function decodeMessageSet (topic, partition, messageSet, cb, maxTickMessages, hi
           });
         }
       });
+    // Skip decoding binary left in the message set if partial message detected
+    if (partial) break;
     // Defensive code around potential denial of service
     if (maxTickMessages && messageCount > maxTickMessages) break;
     messageSet = messageSet.slice(cur);