multipath/multipath.conf.5: Fix find_multipaths documentation #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit c36f2f4 changed the find_multipaths values from yes/no to on/off/strict/greedy. yes/no are still supported as aliases to on/off, but output from `multipathd show config` uses on/off. However, the documentation only listed yes/no, which was particularly confusing when comparing output from `multipathd show config` to the documentation.
mwilck
requested changes
Nov 7, 2023
| @@ -1168,10 +1168,10 @@ listed in the \fBwwids_file\fR. Users can manually set up multipath maps using t | |||
| \fBmultipathd add map\fR command. Once set up manually, the map is | |||
| remembered in the wwids file and will be set up automatically in the future. | |||
| .TP | |||
| .I no | |||
| .I off|no | |||
There was a problem hiding this comment.
I find the vertical bar syntax confusing here. We use it nowhere else in the man page. Can you just put "off", and add "'no' is an alias for 'off'" further down?
| Multipath behaves like \fBstrict\fR. Multipathd behaves like \fBgreedy\fR. | ||
| .TP | ||
| .I yes | ||
| .I on|yes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c36f2f4 changed the find_multipaths values from yes/no to on/off/strict/greedy. yes/no are still supported as aliases to on/off, but output from
multipathd show configuses on/off.However, the documentation only listed yes/no, which was particularly confusing when comparing output from
multipathd show configto the documentation.