Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve inline chat position & completions reporter #3188

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Nov 17, 2023

Types

  • 🎉 New Features

Background or solution

限制 inline chat 不超出编辑区域范围

🤖[deprecated] Generated by Copilot at 5fc0588

  • Add a new command AI_INLINE_COMPLETION_REPORTET for reporting the inline completion statistics (link, link)
  • Register the new command and define a placeholder execute function in ai-chat.contribution.ts (link)
  • Modify the TypeScriptCompletionsProvider class to inject and pass the IAIReporter instance to the ReqStack and RequestImp classes (link, link, link)
  • Modify the sendRequest and pushResultAndRegist methods of the RequestImp class to start and end the reporting process using the aiReporter parameter (link, link, link, link)
  • Add a command property to the InlineCompletionItem object that specifies the AI_INLINE_COMPLETION_REPORTET command with a placeholder argument (link)
  • Modify the AiInlineContentWidget class to prevent the widget from overflowing the editor boundaries and improve its alignment with the cursor (link, link, link, link, link, link, link, link, link, link)
  • Remove an empty line from the completeProvider module (link)
  • Format the pushResultAndRegist method of the RequestImp class to break the long if condition into two lines (link)

Changelog

🤖[deprecated] Generated by Copilot at 5fc0588

This pull request enhances the inline completion feature in the AI chat editor by adding a new command to report usage and performance statistics, improving the chat widget's appearance and behavior, and integrating the reporting function with the completions provider. It also updates the common module with the new command constant.

@Ricbet Ricbet added the v3 OpenSumi 3.0 label Nov 17, 2023
@Ricbet Ricbet requested a review from pipiiiiii November 17, 2023 09:39
@Ricbet Ricbet self-assigned this Nov 17, 2023
@Ricbet Ricbet merged commit a752f32 into chore/ai-native-module Nov 17, 2023
4 checks passed
@Ricbet Ricbet deleted the chore/improve-inline-chat-position branch November 17, 2023 09:40
command: {
id: AI_INLINE_COMPLETION_REPORTET.id,
title: '',
arguments: ['123123123'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是啥

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试参数,忘记删了

@opensumi opensumi bot added the 🎨 feature feature required label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants