Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enable persistent terminal session preference #3127

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Oct 18, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at a6310cc

  • Add a new preference for enabling persistent terminal sessions across window reloads (link, link, link, link)
  • Use the preference value to determine whether to persist terminal clients or not in terminal.controller.ts (link, link, link)

Changelog

🤖 Generated by Copilot at a6310cc

This pull request adds a new feature for terminal users to enable or disable persistent sessions across window reloads. It updates the TerminalController class, the preference service, and the localization files to support this feature.

@opensumi opensumi bot added the 🎨 feature feature required label Oct 18, 2023
@erha19
Copy link
Member

erha19 commented Oct 27, 2023

@Aaaaash 这个指到 main 吧,我记得机器人有个 backport 指令可以发 path 的 PR,不然还得手动一个个回源

@bytemain
Copy link
Member

命令:/backport 分支

@Aaaaash Aaaaash changed the base branch from v2.26 to main November 1, 2023 06:40
@Aaaaash Aaaaash force-pushed the chore/add-disable-terminal-reload-preference branch from a6310cc to cb1b28f Compare November 1, 2023 06:41
@erha19
Copy link
Member

erha19 commented Nov 1, 2023

lint 规则没过 @Aaaaash

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
packages/terminal-next/src/common/preference.ts 100.00% <ø> (+100.00%) ⬆️
...s/terminal-next/src/browser/terminal.controller.ts 33.93% <40.00%> (+33.93%) ⬆️

... and 821 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19
Copy link
Member

erha19 commented Nov 1, 2023

/backport v2.27

@opensumi
Copy link
Contributor

opensumi bot commented Nov 1, 2023

Cannot backport unmerged pull request: #3127

@erha19 erha19 merged commit 9c2998b into main Nov 1, 2023
11 checks passed
@erha19 erha19 deleted the chore/add-disable-terminal-reload-preference branch November 1, 2023 09:53
@erha19
Copy link
Member

erha19 commented Nov 1, 2023

/backport v2.27

@opensumi
Copy link
Contributor

opensumi bot commented Nov 1, 2023

Backporting to v2.27 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

@Aaaaash
Copy link
Member Author

Aaaaash commented Nov 21, 2023

/backport v2.26

@opensumi
Copy link
Contributor

opensumi bot commented Nov 21, 2023

Backporting to v2.26 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants