-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #739 - Issues with Ubuntu 24.04: unmet apt dependencies, icon not showing #740
Conversation
jmarrec
commented
Sep 4, 2024
- Fix [v1.8.0-rc2] Issues with Ubuntu 24.04: unmet apt dependencies, icon not showing. #739
…o debian folder for clarity
@manuvarkey If you can spare the time, I'd really appreciate it if you could please test the installer from this PR on your Ubuntu 24.04 machine! (I don't have a 24.04 VM to test this on, and I'd rather not create one since I plan on upgrading to 24.04 for my machine soonish anyways). Thanks! You should be able to download it from https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/10697681641?pr=740, direct link https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/10697681641/artifacts/1889902113 |
@@ -848,7 +848,7 @@ elseif(UNIX) | |||
# set(CPACK_DEBIAN_PACKAGE_DEBUG ON) | |||
|
|||
# Focal Fossa (20.04) uses libwxgtk3.0-gtk3-0v5, apparently need libxcb-xinerama0 as well | |||
set(CPACK_DEBIAN_PACKAGE_DEPENDS "libxcb-xinerama0 (>= 1.13), libwxgtk3.0-0v5 (>= 3.0.0) | libwxgtk3.0-0 (>=3.0.0) | libwxgtk3.0-gtk3-0v5 (>=3.0.0), libxcb-cursor0") | |||
set(CPACK_DEBIAN_PACKAGE_DEPENDS "libxcb-xinerama0 (>= 1.13), libwxgtk3.0-0v5 (>= 3.0.0) | libwxgtk3.0-0 (>=3.0.0) | libwxgtk3.0-gtk3-0v5 (>=3.0.0) | libwxgtk3.2-1t64 (>= 3.2.0), libxcb-cursor0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add dep alternative for libwxgtk3 for 24.04
@@ -9,4 +9,4 @@ Icon=openstudioapp | |||
Terminal=false | |||
Categories=Utility;X-OpenStudio;X-EnergyModeling; | |||
MimeType=application/x-openstudio; | |||
|
|||
StartupWMClass=OpenStudioApp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's what's missing for 24.04, but not sure.
I tested that it still works on 20.04 with it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xprop WM_CLASS
@manuvarkey I tested this already! thanks |