Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit Water Use Equipment Definition #683

Closed
Ski90Moo opened this issue Feb 28, 2024 · 9 comments · Fixed by #685
Closed

Unable to edit Water Use Equipment Definition #683

Ski90Moo opened this issue Feb 28, 2024 · 9 comments · Fixed by #685

Comments

@Ski90Moo
Copy link

Issue overview

The water use equipment definition is not showing properly on the loads tab. Unable to edit the definition:

Screenshot 2024-02-28 114419

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
    Screenshot 2024-02-28 114721

  • Version of OpenStudioApplication (if using an intermediate build, include SHA):
    Screenshot 2024-02-28 114746

Context

@Ski90Moo Ski90Moo added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Feb 28, 2024
@macumber
Copy link
Collaborator

macumber commented Mar 3, 2024

Thanks @Ski90Moo, I am seeing this too, I will look into it

@macumber macumber added severity - Major Bug 💥 Platform - Windows and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Mar 3, 2024
@macumber
Copy link
Collaborator

macumber commented Mar 4, 2024

@Ski90Moo I think I found the cause of this, it was a too aggressive optimization I made for 1.7.0. I have a PR to fix this, we may include it in a 1.7.1 release. Would you be able to verify it is fixed in one of the local builds here: https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/8135210957?pr=685 ?

@Ski90Moo
Copy link
Author

Ski90Moo commented Mar 14, 2024 via email

@macumber
Copy link
Collaborator

Hey @Ski90Moo no problem. I have a potential fix for this issue, before I merge it in I was hoping you could install a test build and see if it fixes your issue? The test builds are at the bottom of this page: https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/8308713967?pr=685

Here is a direct link to the Windows installer: https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/8308713967/artifacts/1331994577

@macumber macumber self-assigned this Mar 16, 2024
@Ski90Moo
Copy link
Author

Ok, looks good. I don't know if it matters, but when I want to replace the target temperature schedule or fraction schedules, I cannot simply drag in a new schedule. I have to click the delete "x" icon first, then drag in a new one. For internal mass definition, I am able to simply drag in the construction and it will be replaced.
Screenshot 2024-03-19 103814

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 19, 2024

@Ski90Moo I can reproduce the "non-draggable" behavior. Thanks for reporting it. I'll fix it shortly.

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 19, 2024

2b68136 cf demo GIF on the PR at #685 (comment)

@Ski90Moo
Copy link
Author

This appears to be a problem with editing materials as well. I cannot edit window and glazing materials:
image

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 22, 2024

@Ski90Moo yeah, it's the same root cause, #685 fixes it (I just tested with the installers on https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/8343966468?pr=685 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants