Mac app does not alert user if EPW is reset on open

[macumber]

Issue overview

Reported by @brgix in detail here #653 (comment)

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version): Mac M1 13.5
• Version of OpenStudioApplication (if using an intermediate build, include SHA): 1.7.0-rc1

[jmarrec]

Testing with https://github.com/rd2/tbd/blob/402f9f5acaa95e85bfdae33d28ea115e125db683/spec/files/osms/in/warehouse.osm#L6865-L6877

On Ubuntu, no issue. But I can reproduce the lockup of the App on Mac M1 (regardless of whether I use the classic or the C++ CLI)

[jmarrec]

Seems like the issue is the two QMessageBox atop each other or something. It makes the mainwindow lose the focus I think.

If I comment out the lines here:

OpenStudioApplication/src/openstudio_lib/OSDocument.cpp

Lines 356 to 357 in a1f218a

	QMessageBox::warning(mainWindow(), "Missing Weather File",
	"Invalid weather file object, weather file object has been reset. Please choose another weather file.");

then it works fine.

If I make it a direct call (not a QTimer::singleShot) it also works, but the second qmessagebox isn't showed. The one triggered from

OpenStudioApplication/src/openstudio_app/OpenStudioApp.cpp

Line 375 in a1f218a

versionUpdateMessageBox(versionTranslator, true, fileName, openstudio::toPath(m_osDocument->modelTempDir()));

I've also tried making the QMessageBox::warning point to a nullptr parent but that doesn't work either. Tried with OSAppBase::instance()->mainWidget() too

I've also tried moving the call after the waitDialog is hidden and the state of the MainWindow is restored, but wasVisible is actually false yo begin with anyways.

OpenStudioApplication/src/openstudio_lib/OSDocument.cpp

Lines 300 to 309 in a1f218a

	// convert absolute weather file paths to relative in the model, also copy the epw file to the temp dir
	// remove the weather file object if something goes wrong
	bool weatherFileOk = this->fixWeatherFileInTemp(true);
	if (!weatherFileOk) {
	// weather file in model was reset because the file did not exist or it was not a valid EPW
	modified = true;
	// connect to slot that would show user error dialog
	QTimer::singleShot(0, this, &OSDocument::weatherFileReset);
	}

TL;DR: I don't know how to properly fix this one. As a workaround we can hide the dialog box. @macumber Any ideas?

[jmarrec]

Bad workaround for now at #663

[macumber]

Downgraded to regular bug since crash is fixed

[macumber]

New scope of this bug would be to re-enable the warning to the user on Mac