libopenstudiolib.so missing on Ubuntu 18.04 and 20.04 in 1.2.0-rc1 and 1.2.0-rc2

[jmarrec]

Issue overview

libopenstudiolib.so isn't installed anymore, it was in 1.1.0.

Current Behavior

(py39)julien@Downloads$ ls /usr/local/openstudioapplication-1.1.0/bin/libopen*
/usr/local/openstudioapplication-1.1.0/bin/libopenstudiolib.so

(py39)julien@Downloads$ ls /usr/local/openstudioapplication-1.2.0-alpha/bin/libopen*
ls: cannot access '/usr/local/openstudioapplication-1.2.0-alpha/bin/libopen*': No such file or directory

[jmarrec]

1.1.0

./_CPack_Packages/Linux/DEB/OpenStudioApplication-1.1.0-alpha+728d2ea490-Linux/usr/local/openstudioapplication-1.1.0-alpha/lib/libopenstudiolib.so
./_CPack_Packages/Linux/DEB/OpenStudioApplication-1.1.0-alpha+728d2ea490-Linux/usr/local/openstudioapplication-1.1.0-alpha/bin/libopenstudiolib.s

1.2.0

$ find . -name "libopenstudiolib.so"
./_CPack_Packages/Linux/DEB/OpenStudioApplication-1.2.0-alpha+3672aea791-Ubuntu18.04/usr/local/openstudioapplication-1.2.0-alpha/lib/libopenstudiolib.so

Same but in install dirs:

(py39)julien@OSApp-build-release$ find /usr/local/openstudioapplication-1.1.0/ -name "libopenstudio*"
/usr/local/openstudioapplication-1.1.0/lib/libopenstudiolib.so
/usr/local/openstudioapplication-1.1.0/bin/libopenstudiolib.so
(py39)julien@OSApp-build-release$ find /usr/local/openstudioapplication-1.2.0-alpha/ -name "libopenstudio*"
/usr/local/openstudioapplication-1.2.0-alpha/lib/libopenstudiolib.so

[jmarrec]

I've diffed all of our CMakeLists.txt / .cmake files, and I see absolutely no changes that would make this any different... I have no clue how the libopenstudiolib.so ended up also installed in ./bin/ in addition to ./lib/ before. Anyways, I don't think having TWICE the same 70MB library file was a good thing...

[jmarrec]

I tracked the difference down to between 1.1.1-alpha2 and 1.1.1-alpha3

v1.1.1-alpha2...v1.1.1-alpha3

[jmarrec]

And obviously it's my fault.... This is this commit: d2cf6ef

Specifically, the fact that I wrapped the fixup_bundle into the If block, preventing its execution on Linux...

OpenStudioApplication/src/openstudio_app/CMakeLists.txt

Lines 383 to 393 in e47cbb1

	if(WIN32 OR APPLE)
	install(CODE "
	# APPS might be a symbolic link which does not work with fixup_bundle
	# expand APPS to a real path
	get_filename_component(APPS_EXPANDED ${APPS} REALPATH)
	include(BundleUtilities)
	# This file defines some libs we are excluding. Some like concrt140.dll are installed already via InstallRequiredSystemLibraries
	include(\"${CMAKE_SOURCE_DIR}/CMake/FixupBundleOverrides.cmake\")
	fixup_bundle(\"\${APPS_EXPANDED}\" \"${QTPLUGINS}\" \"${DIRS}\")
	" COMPONENT "OpenStudioApp"
	)

Turns out it was also doing sutff on linux, that is copy the libopenstudiolib.so and some other stuff like libicuuc, libQt5QmlModels, etc

libicudata.so.56
libicudata.so.56.1
libicui18n.so.56
libicui18n.so.56.1
libicuuc.so.56
libicuuc.so.56.1
libopenstudiolib.so
libQt5QmlModels.so.5
libQt5QmlModels.so.5.15.0

@macumber that explains why you have to do find_package(Qt5QmlModels in 53c0cef . we should still keep that addition though. I really do not like the fixup_bundle "magic", that feels very fragile to me.

[jmarrec]

Lot more convo/investigation on #95 (comment)