Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVAC library doesn't seem to have CoilCoolingDXVariableSpeed #301

Closed
DavidGoldwasser opened this issue Jan 20, 2021 · 2 comments · Fixed by #455
Closed

HVAC library doesn't seem to have CoilCoolingDXVariableSpeed #301

DavidGoldwasser opened this issue Jan 20, 2021 · 2 comments · Fixed by #455
Assignees
Labels
component - UI Enhancement Request New feature or request good first issue Good for newcomers

Comments

@DavidGoldwasser
Copy link
Contributor

DavidGoldwasser commented Jan 20, 2021

Issue overview

User pointed this out on UH
https://unmethours.com/question/50851/openstudio-adding-coilcoolingdxvariablespeed-as-a-component/

Current Behavior

I see SingleSpeed, TwoSpeed, and TwoStage, but not VariableSpeed

Expected Behavior

Not sure if there is a reason this is not included in the library.

@DavidGoldwasser DavidGoldwasser added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jan 20, 2021
@jmarrec jmarrec added component - UI Enhancement Request New feature or request good first issue Good for newcomers and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jan 21, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented Jan 21, 2021

The reason is that we didn't register that this needed to be added to the library. Which is going to become more common now that objects are added in the SDK but the OSApp is separated (I had added a checklist in the SDK PR template for it previously).

Registering an object is extremely simple, so I'm marking this as a "good first issue" for any one willing to spare 30 minutes.

I have added a wiki entry that should walk you through the process at https://github.com/openstudiocoalition/OpenStudioApplication/wiki/Registering-a-new-SDK-object-in-the-OSApp

@jmarrec
Copy link
Collaborator

jmarrec commented Jan 21, 2021

Haha, apparently there's already an icon ready, and apparently I'm the one that created it https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/src/openstudio_lib/images/cool_coil_dx_vari_speed.png

I suppose I just forgot to list it in MainRightCOlumnController.cpp, and adjust the policy, and add it to hvac_library. So in wiki, just start here: https://github.com/openstudiocoalition/OpenStudioApplication/wiki/Registering-a-new-SDK-object-in-the-OSApp#specify-where-to-display-the-object

@jmarrec jmarrec self-assigned this Oct 29, 2021
jmarrec added a commit that referenced this issue Oct 29, 2021
…ableSpeed

Fix #301 -  Add CoilCoolingDXVariableSpeed to hvac_library and MainRightColumnController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - UI Enhancement Request New feature or request good first issue Good for newcomers
Projects
None yet
2 participants