Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't default to "0" after the user cleared an input field #270

Closed
souliane opened this issue Nov 12, 2020 · 1 comment · Fixed by #313
Closed

Don't default to "0" after the user cleared an input field #270

souliane opened this issue Nov 12, 2020 · 1 comment · Fixed by #313

Comments

@souliane
Copy link

Enhancement Request

When the user clears an input field, leave it empty or default to energyplus default value instead of writing "0".

Detailed Description

Windows 10 Home
OpenStudioApplication 1.1.0

OpenStudioApplication should behave as energyplus when the user clears an input field (i.e. sets its value to "").
IDF Editor will leave the field empty and energyplus will use the default value when simulating.
OpenStudioApplication writes "0", thus forcing overwriting energyplus default.

Example with OS:SpaceInfiltration:DesignFlowRate "Constant Term Coefficient": the default value is "1". If you clear it and focus on another field, "" will be automatically replaced by "0". If you don't pay attention to this and don't read the simulation warnings, it will screw the whole simulation.

Possible Implementation

Either leave it empty (i.e. leave it to energyplus) or default to energyplus default value.
If possible, an help text to explicitly show what the default value is would be a nice addition.

I don't know how easy it is to retrieve energyplus default values, thus leaving the field empty might be the easiest implementation. It is also the best option for allowing an easier maintenance of your models: in case the next version of energyplus uses another default value, you won't "benefit" from it if the current default value is hardcoded in your OSM/IDF file.

@souliane souliane added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Nov 12, 2020
@macumber macumber added severity - Major Bug 💥 and removed Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Nov 24, 2020
@macumber macumber added this to the OpenStudio Application 1.2.0 milestone Nov 24, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Feb 4, 2021

Here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants