API element resources - nested elements #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
AntonKhorev
force-pushed
the
api-element-resources--nested-elements
branch
from
eb1ae8e to
7efcfa2
Compare
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates nested resources instead of the following actions:
ways_for_node,relations_for_node,relations_for_way,relations_for_relation. After that there's no nonstandard actions in api element controllers for current versions of elements.The current structure is a bit surprising too. Here's a route to get ways that include a given node for example:
As you can see the action is not defined in the nodes controller, rather it's in the ways controller. The ways controller receives an id param that's not an id of a way. In this PR I'm adding another controller for ways that include a node, and three more controllers for relations that contain a node/way/relation.