Filter out invisible nodes and ways during initial selection #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
force-pushed
the
map-visible
branch
from
7f13a24 to
b4c0c62
Compare
|
Looks like cgimap only checks visibility when selecting nodes in bbox. It's easier not to check it after that because you can get ids from connector tables ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes #5585 a bit further and drops the separate visibility filtering in favour of ensuring that we always filter for that as part of the initial database query.
Technically this creates a slight change in behaviour in that previous nodes which were visible but outside the bounding box would be returned if they were part of an invisible way that had nodes inside the bounding box but that seems like it was more of a bug than a feature.