Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused visible_nodes hashes from api element controllers #5584

Conversation

AntonKhorev
Copy link
Collaborator

There was a method called to_xml_node defined on way models. It had a cache parameter, and visible_nodes was passed as this parameter in 6300fa2. Later in 363155a xml output was rewritten and to_xml_node was no longer used. The method was removed in 2b1bac1. Same for relations.

However visible_nodes stayed. It's being written to but is never read.

@tomhughes
Copy link
Member

Looks good to me, thanks.

@tomhughes tomhughes merged commit 0a44427 into openstreetmap:master Feb 1, 2025
22 checks passed
@AntonKhorev AntonKhorev deleted the no-api-full-element-visible_nodes branch February 1, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants