Add eslint-plugin-erb to provide linting of .js.erb files #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravitystorm
approved these changes
Jan 27, 2025
HolgerJeromin
approved these changes
Jan 28, 2025
hlfan
force-pushed
the
eslint-plugin-erb
branch
3 times, most recently
from
3d1bb7a to
a8f1c58
Compare
AntonKhorev
reviewed
Feb 4, 2025
hlfan
force-pushed
the
eslint-plugin-erb
branch
from
266988e to
7b421fa
Compare
* Add eslint-plugin-erb to provide linting of our .js.erb files * Lint osm.js.erb and API-ify OSM.params() --------- Co-authored-by: Andy Allan <git@gravitystorm.co.uk>
hlfan
force-pushed
the
eslint-plugin-erb
branch
from
7b421fa to
bc18e85
Compare
gravitystorm
reviewed
Feb 5, 2025
Comment on lines
12
to
15
| "eslint": "^9.0.0", | ||
| "eslint-plugin-erb": "^2.1.0", | ||
| "@stylistic/eslint-plugin-js": "^3.0.0", | ||
| "eslint-formatter-compact": "^8.40.0" |
There was a problem hiding this comment.
How should we sort the plugins?
Either a linter picks up on this, or it doesn't really matter. 😄
For comparison, we use Bundler/OrderedGems for our Gemfile.
It's best to have this sort of thing linted, rather than manually maintained, because if we manually maintain it we need to keep remembering about it, discussing it, and asking new developers to learn the hard way about whatever the un-linted convention is.
|
Merged, thanks for your work on this! |
|
Nice, flattered that you use my plugin now at openstreetmap ;) If anything is not working, just open an issue. And feel free to leave a GitHub star should you like it 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5523
Closes #5549
Includes gravitystorm#296