Code

Note: Add body & author#4481

Code

Closed

grekko wants to merge 23 commits intoopenstreetmap:masteropenstreetmap/openstreetmap-website:masterfrom grekko:notes_refactoring_2grekko/openstreetmap-website:notes_refactoring_2Copy head branch name to clipboard

+473-260

Commits

Commits on Sep 23, 2024

• Extend Note with body & author, update controllers & views

  grekko

  committed
  b82960f

  Copy full SHA for b82960f

• Update Tests to reflect Note refactoring

  grekko

  committed
  3af78f6

  Copy full SHA for 3af78f6

• Add migration task for Notes

  grekko

  committed
  df73264

  Copy full SHA for df73264

• Fix broken references to Factory-definitions

  grekko

  committed
  155f8d7

  Copy full SHA for 155f8d7

• 20240107144209_add_author_and_body_to_notes.rb: Remove data migration SQL

  grekko

  committed
  f46f157

  Copy full SHA for f46f157

• Notes#show: Redact Note#body for deleted authors

  grekko

  committed
  2174fef

  Copy full SHA for 2174fef

• NotesController#show: Filter explicitly for opened-comment

  grekko

  committed
  7027359

  Copy full SHA for 7027359

• Notes: Avoid calls to opened_note_comment once body is migrated

  grekko

  committed
  e7864c9

  Copy full SHA for e7864c9

• Extract Note::MigrateOpenedComment

  grekko

  committed
  358ab82

  Copy full SHA for 358ab82

• Delint app/helpers/note_helper.rb

  grekko

  committed
  e055fb4

  Copy full SHA for e055fb4

• NoteHelper#note_body: Handle missing author, fix tests

  grekko

  committed
  87a4dad

  Copy full SHA for 87a4dad

• api/notes/_note.rss.builder: Do not expose display name of deleted users

  grekko

  committed
  68b86cc

  Copy full SHA for 68b86cc

• Fix Note#build_comments_with_extra_open_comment

  grekko

  committed
  8accc2f

  Copy full SHA for 8accc2f

• api/notes_controller_test.rb: Harden test with more deterministic setup

  Show description for 9be3b43
  grekko

  committed
  9be3b43

  Copy full SHA for 9be3b43

• Api/Notes#feed: Include extra open comment just for migrated notes

  grekko

  committed
  065c33b

  Copy full SHA for 065c33b

• Api/Notes#feed: return only a max of result_limit NoteComment objects

  grekko

  committed
  bf71602

  Copy full SHA for bf71602

• Ditch Note#comments_with_extra_open_comment and ignore opened-event

  grekko

  committed
  866677e

  Copy full SHA for 866677e

• Add Note#api_comments

  grekko

  committed
  9e6109d

  Copy full SHA for 9e6109d

• NotesController#show must only drop first comments if they have been migrated

  grekko

  committed
  2f7d921

  Copy full SHA for 2f7d921

• Fix Note#api_comments, add test for before-migration state

  grekko

  committed
  a40cd37

  Copy full SHA for a40cd37

Commits on Oct 7, 2024

• Merge branch 'master' into notes_refactoring_2

  grekko

  committed
  6726fe8

  Copy full SHA for 6726fe8

• Rename MigrateOpenedComment -> MigrateFirstComment

  grekko

  committed
  af64942

  Copy full SHA for af64942

• MigrateFirstComment should destroy the first-comment when completing

  grekko

  committed
  92c488e

  Copy full SHA for 92c488e