Api/Notes#feed: return only a max of result_limit NoteComment objects

openstreetmap · Feb 26, 2024 · d5feee1 · d5feee1
1 parent 0956142
commit d5feee1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/app/controllers/api/notes_controller.rb b/app/controllers/api/notes_controller.rb
@@ -237,7 +237,12 @@ def feed
         else
           note.comments
         end
-      end
+      end.take(result_limit)
+      # FIXME: notes_refactoring
+      # Migrated and new Note records do not have the extra `open`-NoteComment
+      # so these are synthesized by calling Note#comments_with_extra_open_comment
+      # thus we might be ending up with more NoteComment-objects than asked for
+      # for with result_limit.
 
       # Render the result
       respond_to do |format|