Merge branch 'pull/5627'

openstreetmap · Feb 6, 2025 · a9dcb66 · a9dcb66
2 parents 08359d8 + cb51f46
commit a9dcb66
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app/controllers/notes_controller.rb b/app/controllers/notes_controller.rb
@@ -43,7 +43,7 @@ def show
 
     @note_includes_anonymous = @note.author.nil? || @note_comments.find { |comment| comment.author.nil? }
 
-    @note_comments = @note_comments.drop(1) unless !@note.author.nil? && @note.author.status == "deleted"
+    @note_comments = @note_comments.drop(1) if @note.author.nil? || @note.author.active?
   rescue ActiveRecord::RecordNotFound
     render :template => "browse/not_found", :status => :not_found
   end

diff --git a/test/controllers/notes_controller_test.rb b/test/controllers/notes_controller_test.rb
@@ -152,6 +152,15 @@ def test_read_note_hidden_user_comment
     assert_select "div.note-comments ul li", :count => 1
   end
 
+  def test_read_note_hidden_opener
+    hidden_user = create(:user, :deleted)
+    note_with_hidden_opener = create(:note)
+    create(:note_comment, :author => hidden_user, :note => note_with_hidden_opener)
+
+    sidebar_browse_check :note_path, note_with_hidden_opener.id, "notes/show"
+    assert_select "div.note-comments ul li", :count => 0
+  end
+
   def test_read_closed_note
     user = create(:user)
     closed_note = create(:note_with_comments, :closed, :closed_by => user, :comments_count => 2)