Remove parseFloat calls and restructure

openstreetmap · Feb 4, 2025 · 518936b · 518936b
1 parent 55c1033
commit 518936b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 22 deletions.
diff --git a/app/assets/javascripts/fixthemap.js b/app/assets/javascripts/fixthemap.js
@@ -2,11 +2,7 @@ $(document).ready(function () {
   var params = OSM.params();
 
   var url = "/note/new";
-  if (params.lat && params.lon) {
-    params.lat = parseFloat(params.lat);
-    params.lon = parseFloat(params.lon);
-    params.zoom = params.zoom || 17;
-    url += OSM.formatHash(params);
-  }
+  if (!params.zoom) params.zoom = 17;
+  if (params.lat && params.lon) url += OSM.formatHash(params);
   $(".icon.note").attr("href", url);
 });
diff --git a/app/assets/javascripts/welcome.js b/app/assets/javascripts/welcome.js
@@ -2,28 +2,14 @@ $(document).ready(function () {
   var params = OSM.params();
 
   if (params.lat && params.lon) {
-    params.lat = parseFloat(params.lat);
-    params.lon = parseFloat(params.lon);
-    params.zoom = params.zoom || 17;
-
     var url = "/edit";
 
-    if (params.editor) {
-      url += "?editor=" + params.editor;
-    }
-
+    if (params.editor) url += "?editor=" + params.editor;
+    if (!params.zoom) params.zoom = 17;
     url += OSM.formatHash(params);
 
     $(".start-mapping").attr("href", url);
   } else {
-    var geoSuccess = function (position) {
-      window.location = "/edit" + OSM.formatHash({
-        zoom: 17,
-        lat: position.coords.latitude,
-        lon: position.coords.longitude
-      });
-    };
-
     $(".start-mapping").on("click", function (e) {
       e.preventDefault();
       $(".start-mapping").addClass("loading");
@@ -40,6 +26,14 @@ $(document).ready(function () {
     });
   }
 
+  function geoSuccess(position) {
+    window.location = "/edit" + OSM.formatHash({
+      zoom: 17,
+      lat: position.coords.latitude,
+      lon: position.coords.longitude
+    });
+  }
+
   function manualEdit() {
     window.location = "/?edit_help=1";
   }