Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest adding an entrance=* node to fix 'disconnected highway' errors #10729

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Feb 4, 2025

Closes #6341

If an isolated path or road connects to a building outline, the validator has a new autofix suggestion, which adds entrance=yes or amenity=parking_entrance to the node:

image

@k-yle k-yle added the validation An issue with the validation or Q/A code label Feb 4, 2025
@@ -1971,6 +1971,8 @@ en:
title: Continue drawing from start
continue_from_end:
title: Continue drawing from end
tag_as_entrance:
title: Mark the endpoint as a {presetName}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would be rephrased to remove the indefinite article, any suggestions would be appreciated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to use this pattern in similar situations

Suggested change
title: Mark the endpoint as a {presetName}
title: Mark the endpoint as »{presetName}«

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I think it is a good addition.

Does https://github.com/openstreetmap/iD/pull/10729/files#diff-aa67428c964bd0d0ac6939c0545ffa404cbc3237b1dffec3b2a22491fbac8988R232-R234 mean that this suggestion will either suggest entrance=yes for path like highways and otherwise amenity=parking_entrance?

I wonder if this is the best second option in most cases.

In Berlin, we commonly use barrier=gate for those hw=service ways that connect to a building

Parking entrance is also present sometimes, though https://www.openstreetmap.org/node/8003765396

@@ -1971,6 +1971,8 @@ en:
title: Continue drawing from start
continue_from_end:
title: Continue drawing from end
tag_as_entrance:
title: Mark the endpoint as a {presetName}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to use this pattern in similar situations

Suggested change
title: Mark the endpoint as a {presetName}
title: Mark the endpoint as »{presetName}«

@k-yle
Copy link
Collaborator Author

k-yle commented Feb 4, 2025

Does https://github.com/openstreetmap/iD/pull/10729/files#diff-aa67428c964bd0d0ac6939c0545ffa404cbc3237b1dffec3b2a22491fbac8988R232-R234 mean that this suggestion will either suggest entrance=yes for path like highways and otherwise amenity=parking_entrance?

Yes. Maybe this autofix should only apply to path-like ways? I suspect that isolated vehiclular ways are quite rare, compared to isolated pathways

@tordans
Copy link
Collaborator

tordans commented Feb 4, 2025

Yes. Maybe this autofix should only apply to path-like ways?

Maybe to make this PR easier to merge because I consider this case very clear.

I suspect that isolated vehiclular ways are quite rare, compared to isolated pathways

Actually, we have many such cases in Berlin where a barrier=gate (and maybe barrier=entrance – no gate, just no one added the building passage way, yet) would be welcome additions. See those lines in https://www.openstreetmap.org/#map=19/52.471610/13.444500 for example.

FYI: Those service ways are important data that we add in Berlin to have data that we can use during parking pane processing (https://parkraum.osm-verkehrswende.org/). But those tags at the building are left out often because its already a lot of clicks to add the driveway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnected highway warning should suggest adding entrance nodes
2 participants