-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace info message with clearer version #10711
Conversation
When a user asks for an "Issues" report, and they have no unsaved edits, the message formerly said: You have no edits yet This changes it to say You have no unsaved changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this slightly more precise wording. 👍 We'll merge this right after the upcoming release (in the following days), so that translators have sufficient time to translate this new string.
PS: next time, please omit the dist
directory from the PR, because the files in there are autogenerated and not meant to be included in non-release commits.
I did that because I thought the
If you confirm that this should be removed, I can submit a patch to remove it. |
|
PS: |
Okay, thanks. Would you like me to redo and resubmit my PR, or have you taken care of it? |
I'll fix it while merging. |
merged as ce0eca3 |
When a user asks for an "Issues" report, and they have no unsaved edits, the message formerly said:
which was confusing since the user might have a great many edits.
This commit changes it to say
which is a more accurate description of the situation and communicates the reason that no issues are reported.
The existing
data/core.yaml
sometimes says "unsaved edits" and sometimes "unsaved changes", but "unsaved changes" is more common.I tested this locally in my browser.