Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace info message with clearer version #10711

Closed

Conversation

mjdominus
Copy link
Contributor

When a user asks for an "Issues" report, and they have no unsaved edits, the message formerly said:

   You have no edits yet

which was confusing since the user might have a great many edits.

This commit changes it to say

   You have no unsaved changes

which is a more accurate description of the situation and communicates the reason that no issues are reported.

The existing data/core.yaml sometimes says "unsaved edits" and sometimes "unsaved changes", but "unsaved changes" is more common.

I tested this locally in my browser.

When a user asks for an "Issues" report, and they have no unsaved
edits, the message formerly said:

       You have no edits yet

This changes it to say

       You have no unsaved changes
@tyrasd tyrasd added this to the v3.35 milestone Jan 29, 2025
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this slightly more precise wording. 👍 We'll merge this right after the upcoming release (in the following days), so that translators have sufficient time to translate this new string.

PS: next time, please omit the dist directory from the PR, because the files in there are autogenerated and not meant to be included in non-release commits.

@mjdominus
Copy link
Contributor Author

@tyrasd

PS: next time, please omit the dist directory from the PR, because the files in there are autogenerated and not meant to be included in non-release commits.

I did that because I thought the CONTRIBUTING.md file said to do it:

If you are updating an existing string, update it in data/core.yaml and run
npm run build to generate the en.json file automatically, then commit both
modified files.

If you confirm that this should be removed, I can submit a patch to remove it.

@tyrasd
Copy link
Member

tyrasd commented Jan 30, 2025

Oh, sorry, I forgot about the en.json file. That one should actually be included. Here, you added the en-GB.json file, which is one of the translations that are automatically pulled from Transifex.

@tyrasd
Copy link
Member

tyrasd commented Jan 30, 2025

PS: I see that the .gitignore file was set up the wrong way around. That's why your git client didn't offer you to commit the file. That should be fixed now in the development branch with ffc369d //edit: after taking a second look, it was actually set up as intended. This was changed a while back in #8776, but the contribution guidelines were not updated accordingly. See d39f61f

@mjdominus
Copy link
Contributor Author

Okay, thanks. Would you like me to redo and resubmit my PR, or have you taken care of it?

@tyrasd
Copy link
Member

tyrasd commented Jan 31, 2025

I'll fix it while merging.

@tyrasd
Copy link
Member

tyrasd commented Feb 5, 2025

merged as ce0eca3

@tyrasd tyrasd closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants