-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use biome instead of prettier #561
Conversation
@gulfaraz is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Didn't know about all the biome
recommendations but I really like comes with zero config and is biased.
{/* biome-ignore lint/a11y/useButtonType: */} | ||
<button onClick={() => setTheme("light")}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - wasn't expecting that you should always specify the button type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither did I. This PR was a nice revisit to the basics.
I did make some config choices as specified in biome.json This makes biome ignore the Lines 3 to 8 in b4f722e
This is equivalent to Lines 9 to 11 in b4f722e
This was Lines 18 to 20 in b4f722e
This makes biome ignore all Lines 21 to 25 in b4f722e
You can also disable any rule if you prefer. |
@gulfaraz |
Biome doesn't have tailwind sorting yet, but it is in discussion. So you have a decision to make,
|
I would love to use Biomejs, What's your thought on it? |
|
@gulfaraz |
No problem. |
I think they added some support to class sorting Let's integrate biomejs 🔥 |
The related PR biomejs/biome#1362 (2 weeks ago) is not in their latest release (3 weeks ago) yet. |
closed in favour of #728 |
@gulfaraz Would love if you double check the other PR, it seems like a mess to me 😭 |
resolves #492
search for
biome-ignore
to address migration issues