Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont archive process by default #16

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Dont archive process by default #16

merged 14 commits into from
Jun 7, 2024

Conversation

alexobaseki
Copy link
Contributor

@alexobaseki alexobaseki commented Jun 6, 2024 •
edited by jira bot
Loading

DATA-4855

  • Set is_archive_files conditions for archiving processed files
  • Also added black for linting locally

jessemortenson
jessemortenson requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion and one question that might just be a double check

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
@elseagle elseagle mentioned this pull request Jun 6, 2024
Merged
elseagle
elseagle reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@elseagle elseagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should address this PR before merging

app.py Outdated Show resolved Hide resolved
jessemortenson
jessemortenson approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion re: a variable name

app.py Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
@alexobaseki alexobaseki merged commit a218a7c into main Jun 7, 2024
2 checks passed
@alexobaseki alexobaseki deleted the dont-archive-process/DATA-4855 branch June 7, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elseagle elseagle elseagle left review comments

@jessemortenson jessemortenson jessemortenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexobaseki @jessemortenson @elseagle