Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Insentitive committee name matching #144

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

alexobaseki
Copy link
Contributor

Update matching query to case insensitive. __icontains doesn't work for JSONField and ArrayField so modified other_names to follow "title" naming pattern which is the likely pattern of other_names in the DB.

@alexobaseki alexobaseki changed the title Insentitive committee name matching Case Insentitive committee name matching Sep 27, 2024
@alexobaseki alexobaseki marked this pull request as ready for review September 27, 2024 21:18
Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one small request re: a variable name

openstates/importers/organizations.py Outdated Show resolved Hide resolved
@alexobaseki alexobaseki merged commit d022813 into main Sep 30, 2024
1 check passed
@alexobaseki alexobaseki deleted the insentitive-committee-name-matching branch September 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants