Update ingress apiVersion and make hardcoded variables dynamic #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the deprecation of networking.k8s.io/v1beta1 in favor of networking.k8s.io/v1 in version 1.22 we must update the Ingress structure. IMPORTANT: This requires Kubernetes v1.19 (see https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122).
Badmuts
reviewed
Oct 7, 2022
| const systemIngresses = ['openstad-admin', "openstad-frontend", "openstad-image", "openstad-api", "openstad-auth"]; | ||
| const ingressPrefix = (process.env.KUBERNETES_NAMESPACE ? process.env.KUBERNETES_NAMESPACE : 'openstad'); | ||
|
|
||
| const systemIngresses = [`${ingressPrefix}-admin`, `${ingressPrefix}-frontend`, `${ingressPrefix}-image`, `${ingressPrefix}-api`, `${ingressPrefix}-auth`]; |
There was a problem hiding this comment.
This adds a bug when you are in a different namespace (e.g. acc-2022) but your release name is still openstad.
This will create ingresses with the names openstad-api, openstad-auth etc. but in the namespace acc-2022 and this piece of code will remove the default ingresses.
So this array should be instead:
const systemIngresses = [`${ingressPrefix}-admin`, `${ingressPrefix}-frontend`, `${ingressPrefix}-image`, `${ingressPrefix}-api`, `${ingressPrefix}-auth`, 'openstad-admin', "openstad-frontend", "openstad-image", "openstad-api", "openstad-auth"];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use networking.k8s.io/v1 version for ingress. This PR completes the upgrade to the new ingress apiVersion started in openstad/openstad-kubernetes#71.
IMPORTANT: This requires Kubernetes version v1.19 due to switching from networking.k8s.io/v1beta1 to networking.k8s.io/v1.
See https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122 for more details.
Some ingress values (service name & port for instance) were hardcoded. This PR also uses the already available environment variables to build these ingress values if needed (and falls back to the hardcoded values if they're not). This also fixes the
systemIngressesarray which caused namespaced installations to have theirsystemIngressesremoved, due to not beingopenstad-frontendbutopenstad-NAMESPACE-frontend.Issue reference
Type of change
feature
Documentation
No updated documentation - changelog is updated
Tests
Locally & test cluster
Branch