Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeimprovement/npm audit fix #57

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

nlsvgtr
Copy link
Contributor

@nlsvgtr nlsvgtr commented Aug 8, 2022

Update dependencies. See also #56

rudivanhierden and others added 2 commits August 4, 2022 14:56
Due to an update in the default repositories in the underlying alpine image, python no longer refers to the correct version for our build. Changing it to python3 will allow the build to complete succesfully. See https://stackoverflow.com/questions/62169568/docker-alpine-linux-python-missing

Ideally we'd update to version 18 straight away, but that seems a bit less straightforward. Updating to version 16 (which has security support until september 11th 2023) buys us time to come up with a good strategy to upgrade further.
Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. The downgrade in knex seems to stem from the bookshelf version, which allows us to install without the --legacy-peer-deps flag.

@nlsvgtr nlsvgtr merged commit efba047 into openstad:development Aug 12, 2022
@nlsvgtr nlsvgtr deleted the codeimprovement/npm-audit-fix branch August 12, 2022 10:08
@nlsvgtr
Copy link
Contributor Author

nlsvgtr commented Aug 12, 2022

Yes. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants