Bugfix/flash save session before redirect #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badmuts
approved these changes
May 18, 2022
|
Leuk idee. Mischien later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
express-flash messages are not always saved before a page is redirected. If the redirect happens before the session is saved a flash message is not shown.
Some e2e tests require the message to be shown.
Fix this by adding a explicit req.session.save before the redirect.
Issue reference
Fixes e2e tests errors
See also RGBboy/express-flash#13
and jaredhanson/connect-flash#23
Type of change
Bug fix
Documentation
N/A
Tests
Locally and on AMS staging