Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the global widget from translating if translationwidget is al… #369

Conversation

LorenzoJokhan
Copy link
Contributor

Type of change

Bugfix
Is it a new feature, bug fix, code improvement, etc.
If it is a breaking change what needs to be done to fix that

Documentation

…so on page, better logging and api responses returned
Copy link
Contributor

@nlsvgtr nlsvgtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark, apart from that LGTM.

packages/cms/lib/modules/openstad-global/lib/api.js Outdated Show resolved Hide resolved
@LorenzoJokhan LorenzoJokhan merged commit f164f2f into development Oct 31, 2022
@LorenzoJokhan LorenzoJokhan deleted the bugfix/translations-prevent-unneeded-fetching-and-defer-job-to-widget branch October 31, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants