Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block Ready when OVN is disabled #659

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Feb 8, 2024

The fix f7fe693 introduced a regression. If OVN is disabled in OpenStackControlPlane CR then the CR will never become Ready.

The fix f7fe693 introduced a
regression. If OVN is disabled in OpenStackControlPlane CR then the CR
will never become Ready.
@gibizer gibizer requested a review from booxter February 8, 2024 11:06
@gibizer gibizer requested review from stuggi and removed request for olliewalsh and frenzyfriday February 8, 2024 11:07
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karelyatin
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, SeanMooney, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1e3b213697a24074a9996de2928445e3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 28s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 03s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 24m 16s

@gibizer
Copy link
Contributor Author

gibizer commented Feb 8, 2024

recheck

2024-02-08 06:37:03.027752 | controller | Error from server (InternalError): Internal error occurred: unexpected response: 400
2024-02-08 06:37:03.034919 | controller | Can not login to the CRC cluster. Sleeping...
2024-02-08 11:37:08.336262 | controller | ERROR

@booxter
Copy link
Contributor

booxter commented Feb 8, 2024

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c294c25a93444203b4737cfd86ed578f

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 16m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 33s
cifmw-crc-podified-edpm-baremetal TIMED_OUT in 3h 00m 38s
openstack-operator-tempest-multinode FAILURE in 1h 36m 10s

@booxter
Copy link
Contributor

booxter commented Feb 8, 2024

recheck

services 503/504 at random (I see keystone, neutron and others failing to process http requests.) I don't think there's an issue in the PR itself.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b7a8cd17f806484b974f2d96fb69a22f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 53s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 10s
cifmw-crc-podified-edpm-baremetal FAILURE in 33m 49s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 24m 48s

@booxter
Copy link
Contributor

booxter commented Feb 9, 2024

recheck

FAILED - RETRYING: [localhost]: Wait for OpenStack subscription creation (1 retries left).
fatal: [localhost]: FAILED! => {"attempts": 30, "changed": true, "cmd": ["oc", "get", "sub", "openstack-operator", "--namespace=openstack-operators", "-o=jsonpath={.status.installplan.name}"], "delta": "0:00:00.117832", "end": "2024-02-08 17:06:05.780264", "msg": "", "rc": 0, "start": "2024-02-08 17:06:05.662432", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b2521b07013e40d48df82c9ed55299a6

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 17m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 18s
cifmw-crc-podified-edpm-baremetal TIMED_OUT in 3h 00m 32s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 36m 11s

@gibizer
Copy link
Contributor Author

gibizer commented Feb 9, 2024

recheck

1 similar comment
@gibizer
Copy link
Contributor Author

gibizer commented Feb 9, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1bc91e70d71a47c597c3d762ea58f62a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 16s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 5m 33s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 35s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 23m 58s

@SeanMooney
Copy link
Contributor

check-rdo

@openshift-merge-bot openshift-merge-bot bot merged commit 04deeb6 into openstack-k8s-operators:main Feb 9, 2024
7 checks passed
@gibizer gibizer deleted the allow-disabling-ovn branch July 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants