Merge pull request #50 from rabi/OSImage

Drop webhook validation for OSImage
openstack-k8s-operators · Jul 12, 2023 · 02c7bec · 02c7bec
2 parents d4214e4 + 2cc93fd
commit 02c7bec
Showing 1 changed file with 2 additions and 19 deletions.
diff --git a/api/v1beta1/openstackbaremetalset_webhook.go b/api/v1beta1/openstackbaremetalset_webhook.go
@@ -78,7 +78,7 @@ func (r *OpenStackBaremetalSet) ValidateCreate() error {
 		return err
 	}
 
-	return r.validateCr()
+	return nil
 }
 
 // ValidateUpdate implements webhook.Validator so a webhook will be registered for the type
@@ -149,7 +149,7 @@ func (r *OpenStackBaremetalSet) ValidateUpdate(old runtime.Object) error {
 		}
 	}
 
-	return r.validateCr()
+	return nil
 
 }
 
@@ -159,20 +159,3 @@ func (r *OpenStackBaremetalSet) ValidateDelete() error {
 
 	return nil
 }
-
-func (r *OpenStackBaremetalSet) validateCr() error {
-	if err := r.checkBaseImageReqs(); err != nil {
-		return err
-	}
-
-	return nil
-}
-
-func (r *OpenStackBaremetalSet) checkBaseImageReqs() error {
-	// TODO(rabi): Uncomment after dataplane-operator api bump
-	// if r.Spec.OSImage == "" && r.Spec.ProvisionServerName == "" {
-	//	 return fmt.Errorf("either \"osImage\" or \"provisionServerName\" must be provided")
-	// }
-
-	return nil
-}