Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global BeforeEach and remove duplicate code #297

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Mar 21, 2023

Global BeforeEach is supported by ginkgo intentionally based on:

@openshift-ci openshift-ci bot requested review from bogdando and kk7ds March 21, 2023 09:43
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for tracking down that this is intentionally supported.

@openshift-ci openshift-ci bot removed the lgtm label Mar 21, 2023
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice reduction of our code duplication. Thanks for finding out a solution for it.

@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrKisaoLamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@mrkisaolamb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/nova-operator-build-deploy a3a131a link false /test nova-operator-build-deploy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4c13a94 into master Mar 21, 2023
@mrkisaolamb mrkisaolamb deleted the test_global_setup branch April 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants