Fix keystone template for fernet keys #491
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afaranha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -22,7 +22,7 @@ enforce_scope = {{ .enableSecureRBAC }} | |||
|
|
|||
| [fernet_tokens] | |||
| key_repository=/etc/keystone/fernet-keys | |||
| max_active_keys=2 | |||
| max_active_keys={{ .fernetMaxActiveKeys }} | |||
There was a problem hiding this comment.
you have to pass it into the template parameters https://github.com/openstack-k8s-operators/keystone-operator/blob/main/controllers/keystoneapi_controller.go#L1182
maybe also enhance the functional tests as part of this PR?
There was a problem hiding this comment.
I`m working on that, should I submit all together?
There was a problem hiding this comment.
that would be good to have the fix tested
|
@afaranha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing in favor of #492 |
No description provided.