Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] enhance functional tests to check all fernet keys #490

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Oct 22, 2024

Checks all fernet keys are rotated correct:

  • old idx 0 > new 4
  • old idx > new idx-1
  • old idx 1 must be gone and not match new idx 0

Checks all fernet keys are rotated correct:
* old idx 0 > new 4
* old idx   > new idx-1
* old idx 1 must be gone and not match new idx 0

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi stuggi requested review from xek and olliewalsh and removed request for dprince and lewisdenny October 22, 2024 06:30
@xek xek requested a review from afaranha October 22, 2024 06:31
Copy link
Contributor

@xek xek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Thanks!

@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2024
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi, xek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b365649 into openstack-k8s-operators:main Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants