Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping install NMstate #934

Conversation

pablintino
Copy link
Contributor

In case it's already installed the user may want to skip installing NMstate.

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

In case it's already installed the user may want to skip installing NMstate.
@pablintino pablintino marked this pull request as ready for review October 18, 2024 20:25
@openshift-ci openshift-ci bot requested review from slagle and viroel October 18, 2024 20:25
@pablintino pablintino requested review from abays and stuggi and removed request for slagle and viroel October 18, 2024 20:25
Copy link
Contributor

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

No change to the default behavior but if INSTALL_NMSTATE set to false, nmstate won't be installed, only nncp will be applied.

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, lewisdenny, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f998b0a into openstack-k8s-operators:main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants