Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gen-edpm-node-bootc.sh for creating bootc based nodes #931

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add gen-edpm-node-bootc.sh for creating bootc based nodes #931

wants to merge 2 commits into from
+408 −269

Conversation

slagle
Copy link
Contributor

@slagle slagle commented Oct 16, 2024

  • Refactor common EDPM node code into gen-edpm-node-common.sh
  • Add gen-edpm-node-bootc.sh for creating bootc based nodes

@slagle
Refactor common EDPM node code into gen-edpm-node-common.sh
b4351c4 
Allows the common bits of node creation to be used in different scripts.

Signed-off-by: James Slagle <jslagle@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e2b0070f6b30474f9bcbf250dd709477

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 36s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 27m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 55s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 55m 14s
❌ adoption-standalone-to-crc-no-ceph-provider FAILURE in 1h 12m 07s

@slagle
Add gen-edpm-node-bootc.sh for creating bootc based nodes
025a56c 
Also adds a new Makefile target:
make edpm_compute_bootc

Depends on the image that will eventually be published at
quay.io/openstack-k8s-operators/edpm-bootc:latest

See openstack-k8s-operators/edpm-image-builder#37

Signed-off-by: James Slagle <jslagle@redhat.com>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63a3d5b2bcf245a1b69e519d16f01220

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 31m 51s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 24m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 08s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 16m 30s
❌ adoption-standalone-to-crc-no-ceph-provider FAILURE in 2h 14m 20s

rabi
rabi reviewed Oct 25, 2024
View reviewed changes
devsetup/scripts/gen-edpm-node-bootc.sh
genisoimage -output ${EDPM_BOOTC_OUTPUT_DIR}/cidata.iso -V CIDATA -r -J ${EDPM_BOOTC_OUTPUT_DIR}/user-data ${EDPM_BOOTC_OUTPUT_DIR}/meta-data ${EDPM_BOOTC_OUTPUT_DIR}/network-config
fi

sudo podman run --rm -it --privileged \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we can't just use the image built by edpm-image-builder? We can change the scripts to pass user-data/network-config with 'virt-install --cloud-init`(?) [1].

[1] https://github.com/virt-manager/virt-manager/blob/main/man/virt-install.rst#--cloud-init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabi rabi rabi left review comments

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slagle @rabi