Cleanup/fix how we manage DeploymentReadyCondition #931
Conversation
rabi
force-pushed
the
conditions
branch
2 times, most recently
from
d68d15c
to
f4e6130
Compare
|
/test precommit-check |
|
/test dataplane-operator-build-deploy-kuttl |
- Don't use deployemnt.Deployed as there could be more than one nodeset in a deployment. - Check NodeSetDeploymentReadyCondition for the nodeset rather than Ready condition for the deployment. - Break when a failed deployment for a nodeset is encountered. Continuing can overwrite the nodeset deployment conditions. Signed-off-by: rabi <ramishra@redhat.com>
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/159b95a57d6c498fb99f5834600d6087 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 25s |
|
zuul jobs require openstack-k8s-operators/install_yamls#847 |
|
recheck |
this aspect looks missing in the source jira issue. Wouldn't it change the users expectations about tolerating a partial failure of some edpm nodes during rhoso deployment, which also had been demoed recently? |
Partial failure is handled in ansible and AEE jobs won't fail if max_fail_percentage > 0 and failed node count for a play is within the tolerated value. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
recheck |
openshift-merge-bot
bot
merged commit f057a68
into
openstack-k8s-operators:main
Jira: https://issues.redhat.com/browse/OSPRH-7617
Depends-On: openstack-k8s-operators/install_yamls#847