This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Make TLS cert mount order consisitent #928
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We iterate over the TLSCerts map to define the cert mounts. Because this is a map, though, the order is undefined. This causes kuttl tests to fail every so often because they expect a consistent mount order. The simplest solution is to sort the map keys and then add the mounts in a consistent way.
fao89
approved these changes
Jun 7, 2024
slagle
approved these changes
Jun 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, slagle, vakwetu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit 49b2cd8
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We iterate over the TLSCerts map to define the cert mounts. Because this is a map, though, the order is undefined. This causes kuttl tests to fail every so often because they expect a consistent mount order.
The simplest solution is to sort the map keys and then add the mounts in a consistent way.