Add ci_kustomize action plugin #511

pablintino · 2023-09-04T15:36:47Z

This action plugin is a direct replacement of the edpm_kustomize role. It takes a path to the file you want to kustomize and applies a set of kustomizations given though it's kustomizations parameter or through file ones placed on the same directory where the target manifest is placed.

As a pull request owner and reviewers, I checked that:

Appropriate testing is done and actually running
Appropriate documentation exists and/or is up-to-date:
- README in the role
- Content of the docs/source is reflecting the changes

openshift-ci · 2023-09-04T15:36:51Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

softwarefactory-project-zuul · 2023-09-11T11:07:26Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4847591151aa4d86aa8d8ba38231e4c7

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 47m 31s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 50m 13s

softwarefactory-project-zuul · 2023-09-12T07:15:45Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9f1e2a7b9d064f4f958c2e80862493d2

✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 02s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 44m 07s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 41m 37s

softwarefactory-project-zuul · 2023-09-14T18:06:33Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cb12bc354cb748f996f225ea176895c3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 07m 13s
❌ podified-multinode-edpm-deployment-crc FAILURE in 53m 36s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 42m 19s

softwarefactory-project-zuul · 2023-09-14T19:41:35Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5f3d076ddbf24c28bf65e356d556967e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 43s
❌ podified-multinode-edpm-deployment-crc FAILURE in 55m 59s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 41m 39s

softwarefactory-project-zuul · 2023-09-15T09:07:36Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d131a720c0cd465fa8f864ddc7f7c958

✔️ openstack-k8s-operators-content-provider SUCCESS in 15m 58s
❌ podified-multinode-edpm-deployment-crc MERGE_CONFLICT in 3s
✔️ noop SUCCESS in 0s
✔️ podified-multinode-edpm-e2e-nobuild-tagged-crc SUCCESS in 42m 38s

softwarefactory-project-zuul · 2023-09-18T17:08:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/32835189099046d2a835789a2414a9cc

❌ openstack-k8s-operators-content-provider MERGE_CONFLICT in 7s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ podified-multinode-edpm-e2e-nobuild-tagged-crc SUCCESS in 37m 19s

softwarefactory-project-zuul · 2023-09-19T08:17:16Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/aa3998bc78b54346a28b0f660aa8c4a7

✔️ openstack-k8s-operators-content-provider SUCCESS in 49m 43s
❌ podified-multinode-edpm-deployment-crc FAILURE in 37m 27s
✔️ noop SUCCESS in 0s
✔️ podified-multinode-edpm-e2e-nobuild-tagged-crc SUCCESS in 36m 10s

softwarefactory-project-zuul · 2023-09-19T11:35:44Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/44936c1567c041078cf65ad856f1d349

✔️ openstack-k8s-operators-content-provider SUCCESS in 53m 39s
❌ podified-multinode-edpm-deployment-crc FAILURE in 39m 41s
✔️ noop SUCCESS in 0s
✔️ podified-multinode-edpm-e2e-nobuild-tagged-crc SUCCESS in 40m 09s

softwarefactory-project-zuul · 2023-09-19T18:27:51Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/94efbf50e22d4f50b7fa3977d5337c65

✔️ openstack-k8s-operators-content-provider SUCCESS in 53m 30s
❌ podified-multinode-edpm-deployment-crc FAILURE in 38m 52s
✔️ noop SUCCESS in 0s
✔️ podified-multinode-edpm-e2e-nobuild-tagged-crc SUCCESS in 41m 54s
❌ cifmw-molecule-edpm_deploy FAILURE in 5m 13s

softwarefactory-project-zuul · 2023-09-19T21:42:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b8dc18235b604c3d9c809e806de04f1b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 07m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 24s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 43m 19s

raukadah

Thank you @pablintino for working on this. Overall it looks good from first glance. I will go over the code one more time.

raukadah · 2023-09-20T06:42:50Z

ci_framework/plugins/action/ci_kustomize.py

+    returned: success
+    type: int
+    sample: 10
+kustomizations_paths: typing.List[str]


I think it should be kustomizations_paths: without typing.List[str]

Good catch!

This action plugin is a direct replacement of the edpm_kustomize role. It takes a path to the file you want to kustomize and applies a set of kustomizations given though it's kustomizations parameter or through file ones placed on the same directory where the target manifest is placed.

softwarefactory-project-zuul · 2023-09-20T08:29:26Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6ae216a3406a442bb24ac38f1326aaa6

✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 46m 58s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 46m 41s

pablintino · 2023-09-20T08:32:41Z

recheck

marios

/lgtm

cjeanner · 2023-09-20T11:33:06Z

/approve

openshift-ci · 2023-09-20T11:33:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cjeanner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pablintino · 2023-09-20T11:56:08Z

/test pre-commit

pablintino added the do-not-merge/work-in-progress label Sep 4, 2023

pablintino requested a review from cjeanner September 4, 2023 15:36

rabi mentioned this pull request Sep 5, 2023

scripts: Add Additional Kustomization For Baremetal Deployment openstack-k8s-operators/install_yamls#494

Open

pablintino force-pushed the edpm_kustomize/action-module branch 4 times, most recently from 20e31f6 to f0f8160 Compare September 11, 2023 10:15

pablintino force-pushed the edpm_kustomize/action-module branch 2 times, most recently from 5f458b5 to 2b61f2f Compare September 12, 2023 06:18

pablintino force-pushed the edpm_kustomize/action-module branch 7 times, most recently from d833d7d to 8270e3b Compare September 14, 2023 16:57

pablintino force-pushed the edpm_kustomize/action-module branch from 8270e3b to ba440d9 Compare September 14, 2023 18:29

pablintino force-pushed the edpm_kustomize/action-module branch from ba440d9 to b8fbd70 Compare September 15, 2023 08:21

pablintino force-pushed the edpm_kustomize/action-module branch 6 times, most recently from 938bdd4 to b478197 Compare September 18, 2023 05:57

pablintino mentioned this pull request Sep 18, 2023

Replace edpm_kustomize with ci_kustomize #569

Merged

2 tasks

pablintino force-pushed the edpm_kustomize/action-module branch from d83cbc5 to b066e49 Compare September 18, 2023 16:29

pablintino force-pushed the edpm_kustomize/action-module branch from b066e49 to 153cf3a Compare September 19, 2023 07:26

pablintino force-pushed the edpm_kustomize/action-module branch 2 times, most recently from 6f24763 to fbe7fdf Compare September 19, 2023 10:39

pablintino force-pushed the edpm_kustomize/action-module branch 4 times, most recently from 3da960f to 876bf80 Compare September 19, 2023 17:02

pablintino force-pushed the edpm_kustomize/action-module branch from 876bf80 to a2b5a25 Compare September 19, 2023 20:31

raukadah reviewed Sep 20, 2023

View reviewed changes

pablintino force-pushed the edpm_kustomize/action-module branch from a2b5a25 to 299054e Compare September 20, 2023 07:27

pablintino force-pushed the edpm_kustomize/action-module branch from 299054e to 6dbcca2 Compare September 20, 2023 07:28

marios approved these changes Sep 20, 2023

View reviewed changes

openshift-ci bot assigned marios Sep 20, 2023

openshift-ci bot added the lgtm label Sep 20, 2023

openshift-ci bot added the approved label Sep 20, 2023

openshift-merge-robot merged commit 8333b8f into main Sep 20, 2023
7 checks passed

openshift-merge-robot deleted the edpm_kustomize/action-module branch September 20, 2023 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ci_kustomize action plugin #511

Add ci_kustomize action plugin #511

pablintino commented Sep 4, 2023 •

edited

Loading

openshift-ci bot commented Sep 4, 2023

softwarefactory-project-zuul bot commented Sep 11, 2023

softwarefactory-project-zuul bot commented Sep 12, 2023

softwarefactory-project-zuul bot commented Sep 14, 2023

softwarefactory-project-zuul bot commented Sep 14, 2023

softwarefactory-project-zuul bot commented Sep 15, 2023

softwarefactory-project-zuul bot commented Sep 18, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

raukadah left a comment

raukadah Sep 20, 2023

pablintino Sep 20, 2023

softwarefactory-project-zuul bot commented Sep 20, 2023

pablintino commented Sep 20, 2023

marios left a comment

cjeanner commented Sep 20, 2023

openshift-ci bot commented Sep 20, 2023

pablintino commented Sep 20, 2023

Add ci_kustomize action plugin #511

Add ci_kustomize action plugin #511

Conversation

pablintino commented Sep 4, 2023 • edited Loading

openshift-ci bot commented Sep 4, 2023

softwarefactory-project-zuul bot commented Sep 11, 2023

softwarefactory-project-zuul bot commented Sep 12, 2023

softwarefactory-project-zuul bot commented Sep 14, 2023

softwarefactory-project-zuul bot commented Sep 14, 2023

softwarefactory-project-zuul bot commented Sep 15, 2023

softwarefactory-project-zuul bot commented Sep 18, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

softwarefactory-project-zuul bot commented Sep 19, 2023

raukadah left a comment

Choose a reason for hiding this comment

raukadah Sep 20, 2023

Choose a reason for hiding this comment

pablintino Sep 20, 2023

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Sep 20, 2023

pablintino commented Sep 20, 2023

marios left a comment

Choose a reason for hiding this comment

cjeanner commented Sep 20, 2023

openshift-ci bot commented Sep 20, 2023

pablintino commented Sep 20, 2023

pablintino commented Sep 4, 2023 •

edited

Loading