-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ci_kustomize action plugin #511
Conversation
Skipping CI for Draft Pull Request. |
20e31f6
to
f0f8160
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4847591151aa4d86aa8d8ba38231e4c7 ✔️ noop SUCCESS in 0s |
5f458b5
to
2b61f2f
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9f1e2a7b9d064f4f958c2e80862493d2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 02s |
d833d7d
to
8270e3b
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cb12bc354cb748f996f225ea176895c3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 07m 13s |
8270e3b
to
ba440d9
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5f3d076ddbf24c28bf65e356d556967e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 43s |
ba440d9
to
b8fbd70
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d131a720c0cd465fa8f864ddc7f7c958 ✔️ openstack-k8s-operators-content-provider SUCCESS in 15m 58s |
938bdd4
to
b478197
Compare
d83cbc5
to
b066e49
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/32835189099046d2a835789a2414a9cc ❌ openstack-k8s-operators-content-provider MERGE_CONFLICT in 7s |
b066e49
to
153cf3a
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/aa3998bc78b54346a28b0f660aa8c4a7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 49m 43s |
6f24763
to
fbe7fdf
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/44936c1567c041078cf65ad856f1d349 ✔️ openstack-k8s-operators-content-provider SUCCESS in 53m 39s |
3da960f
to
876bf80
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/94efbf50e22d4f50b7fa3977d5337c65 ✔️ openstack-k8s-operators-content-provider SUCCESS in 53m 30s |
876bf80
to
a2b5a25
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b8dc18235b604c3d9c809e806de04f1b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 07m 57s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pablintino for working on this. Overall it looks good from first glance. I will go over the code one more time.
returned: success | ||
type: int | ||
sample: 10 | ||
kustomizations_paths: typing.List[str] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be kustomizations_paths:
without typing.List[str]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
a2b5a25
to
299054e
Compare
This action plugin is a direct replacement of the edpm_kustomize role. It takes a path to the file you want to kustomize and applies a set of kustomizations given though it's kustomizations parameter or through file ones placed on the same directory where the target manifest is placed.
299054e
to
6dbcca2
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6ae216a3406a442bb24ac38f1326aaa6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 43s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pre-commit |
This action plugin is a direct replacement of the edpm_kustomize role. It takes a path to the file you want to kustomize and applies a set of kustomizations given though it's kustomizations parameter or through file ones placed on the same directory where the target manifest is placed.
As a pull request owner and reviewers, I checked that: