Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create xml results file to validations role #2456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drosenfe
Copy link

Add generation of xml results file to validations role. This will allow polarion status reporting for validations.

@github-actions github-actions bot marked this pull request as draft October 14, 2024 18:17
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

Hi @drosenfe. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5539da889374d38806c95d594d89b53

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
cifmw-pod-pre-commit FAILURE in 7m 34s
✔️ build-push-container-cifmw-client SUCCESS in 37m 52s
✔️ cifmw-molecule-validations SUCCESS in 4m 41s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cf725184fc7a490aacc910ad4cdc6489

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 24s
cifmw-pod-pre-commit FAILURE in 7m 20s
build-push-container-cifmw-client FAILURE in 15m 43s
✔️ cifmw-molecule-validations SUCCESS in 3m 56s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/31370ac9596b472daa36cebad50d2757

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 16s
cifmw-pod-pre-commit FAILURE in 7m 07s
build-push-container-cifmw-client FAILURE in 15m 48s
✔️ cifmw-molecule-validations SUCCESS in 4m 02s

@drosenfe
Copy link
Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df2950cb83144d738cf509d8362894e0

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 54s
cifmw-pod-pre-commit FAILURE in 7m 32s
build-push-container-cifmw-client FAILURE in 15m 43s
✔️ cifmw-molecule-validations SUCCESS in 4m 11s

@lewisdenny
Copy link
Collaborator

/ok-to-test

Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is working to get the data you need into Polarion then it lgtm. Just some follow up tidying that we can do, but realistically it's orthogonal to this change anyway. I don't want to distract from the objective of the PR with that conversation here, this change just draws attention to that requirement for me.

roles/validations/tasks/main.yml Show resolved Hide resolved
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

JFYI we have roles/polarion for uploading the polarion xml once ready.

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lewisdenny lewisdenny requested a review from a team October 23, 2024 01:03
@bshephar
Copy link
Contributor

/approve

JFYI we have roles/polarion for uploading the polarion xml once ready.

I think ultimately, what might be nice as a follow up to this PR is a new task file in the polarion role that will take some Ansible variable inputs, and use a jinja2 template to format those results into the required XML for polarion. Then instead of all the XML handling we're doing in this PR, we can simply call import tasks_from that new polarion file and it can handle to XML side of things.

But since this is only going to impact the EDPM validations, it's fairly limited impact if something were to stop working for some reason. I'm in favor of merging it to keep progress going, and maybe we can backlog a Epic to tidy up the XML side of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants