-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test_operator] Update var name for tempest override_scenario bools #1095
[test_operator] Update var name for tempest override_scenario bools #1095
Conversation
For testing: This is being tested in [1]. For docs: [1] openstack-k8s-operators/telemetry-operator#284 |
56bb68d
to
4157f00
Compare
After passing the cifmw_test_operator_tempest_include_list var to the role, the following error occurred in roles/test_operator/tasks/tempest-tests.yml': line 22 'cifmw_test_operator_tempest_tests_include_override_scenario' is undefined Previously, the first condition was false and caused the check to fail. Now that that var is defined, the second condition is being evaluated. The cifmw_test_operator_tempest_tests_include_override_scenario var does not have a default set in default/main.yml However, defaults/main.yml defines: cifmw_test_operator_tests_include_override_scenario: false cifmw_test_operator_tests_exclude_override_scenario: false The names of the vars were updated so that this bool is defined.
4157f00
to
db0b3f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! LGTM:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fa2fcee
into
openstack-k8s-operators:main
After passing the cifmw_test_operator_tempest_include_list var to the role, the following error occurred in roles/test_operator/tasks/tempest-tests.yml': line 22
'cifmw_test_operator_tempest_tests_include_override_scenario' is undefined
Previously, the first condition was false and caused the check to fail. Now that that var is defined, the second condition is being evaluated.
The cifmw_test_operator_tempest_tests_include_override_scenario var does not have a default set in default/main.yml
However, defaults/main.yml defines:
cifmw_test_operator_tests_include_override_scenario: false cifmw_test_operator_tests_exclude_override_scenario: false
The names of the vars were updated so that this bool is defined.
As a pull request owner and reviewers, I checked that: