Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait_with_output forget to close stdin #172

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: wait_with_output forget to close stdin #172

merged 1 commit into from
Nov 27, 2024

Conversation

dovahcrow
Copy link
Contributor

No description provided.

@jonhoo
Copy link
Collaborator

jonhoo commented Nov 27, 2024

This change is Reviewable

NobodyXu
NobodyXu approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (bacc76d) to head (3d661a4).
Report is 19 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
src/child.rs 91.89% <100.00%> (+2.14%) ⬆️

... and 14 files with indirect coverage changes

@NobodyXu NobodyXu merged commit 31bde68 into openssh-rust:master Nov 27, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dovahcrow @jonhoo @codecov-commenter @NobodyXu