-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Port forwarding closure #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for putting up this PR!
I will a few suggestions, and it looks great to me!
I checked socket closure by checking whether |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Quickly implemented port forwarding closure.
Reference: https://github.com/openssh/openssh-portable/blob/059ed698a47c9af541a49cf754fd09f984ac5a21/PROTOCOL.mux#L189
The request is pretty much the exact same as requesting port forwarding, except that the protocol code is
MUX_C_CLOSE_FWD
(0x10000007) and the server does not return aMUX_S_REMOTE_PORT
.I realized that the verb "close" aligns better with the protocol doc's language than "cancel". If this gets merged, on the
openssh
repo, I think I'll rename the APIs (i.e., replace "cancel" with "close").CC. @NobodyXu