Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Create Dataclerk App #2630

Merged
merged 88 commits into from
Aug 2, 2023
Merged

[MWCore] Create Dataclerk App #2630

merged 88 commits into from
Aug 2, 2023

Conversation

sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2630 (082be97) into mwcore-dev (ef5f9fa) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             mwcore-dev   #2630   +/-   ##
============================================
  Coverage          67.4%   67.5%           
  Complexity          878     878           
============================================
  Files               160     160           
  Lines              7139    7126   -13     
  Branches            998     991    -7     
============================================
- Hits               4818    4816    -2     
+ Misses             1692    1686    -6     
+ Partials            629     624    -5     
Flag Coverage Δ
engine 67.5% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...smartregister/fhircore/engine/sync/NetworkState.kt 100.0% <100.0%> (+73.3%) ⬆️

@sevenreup sevenreup marked this pull request as ready for review August 2, 2023 08:23
@sevenreup sevenreup requested a review from LZRS August 2, 2023 08:23
@sevenreup sevenreup self-assigned this Aug 2, 2023
@sevenreup sevenreup merged commit 5a62272 into mwcore-dev Aug 2, 2023
@sevenreup sevenreup deleted the mw-dataclerk branch August 2, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants