Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default passwords from server.cfg. #18

Merged

Conversation

BranDougherty
Copy link
Member

My PR #15 introduced default server and admin passwords. This is really a terrible idea for a soldat.smod release, these should be set in a server owner's custom server.cfg instead. A better fix is to just make it more obvious that these lines are commented out.

Copy link

@michaelblyons michaelblyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this format would help?

//// admin password
// sv_adminpassword "test"

@BranDougherty BranDougherty merged commit 197bb3d into opensoldat:master Jun 30, 2021
@BranDougherty BranDougherty deleted the remove-default-passwords branch April 14, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants