Replace Array.rfindIndex with findIndex to work around bug with Array #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray implementation for now
nickbianco
approved these changes
Mar 18, 2024
|
This was a workaround for a bug introduced on core, this has been fixed there so no need for the workaround. Will test artifact and close if issue is fixed without this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1496
Brief summary of changes
The new Array implementation returns incorrect/different index for rfindIndex than the legacy code. While the call site has been updated the funtion rfindIndex should be fixed for backward compatibility for possible use in client code elsewhere.
Testing I've completed
Plots in the GUI
CHANGELOG.md (choose one)