Make model marker less shiny

[aymanhab]

Fixes issue #1107

Brief summary of changes

Change material specification of model markers to match those of experimental markers for consistency. Along with opensim-core fix to scale factors these two fixes combined result in better looking model markers.

Testing I've completed

Created new markers, loaded models with markers and inspected visualization

CHANGELOG.md (choose one)

-updated

[aymanhab]

@jimmyDunne If you review and merge will get an Artifact of the gui with integrated fix.

[jimmyDunne]

They are definitely different. I have a few comments just as impressions as I looked at it for the first time.

From a not-so-far distance away, the markers appear more 'black' than pink.

If I would have to guess, it may because the dark shading on the marker is on the superior surface of the maker, rather than than the infererior. The experimental markers seem to have the darker shading on the inferior surface of the sphere, which we may want to mimick. I think that would help the Model marker pink coloring to stand out.

[aymanhab]

James, the wrong shading suggest this build of the gui does not have the core fix. I can restart the gui build to force that unless you locally built latest master on both core and gui.

…

On Thu, Oct 3, 2019, 6:31 AM jimmyDunne ***@***.***> wrote: They are definitely different. I have a few comments just as impressions as I looked at it for the first time. From a not-so-far distance away, the markers appear more 'black' than pink. [image: image] <https://user-images.githubusercontent.com/5296507/66130552-e2e9d400-e5bf-11e9-8e2a-fa3c554c53ac.png> If I would have to guess, it may because the dark shading on the marker is on the superior surface of the maker, rather than than the infererior. The experimental markers seem to have the darker shading on the inferior surface of the sphere, which we may want to mimick. I think that would help the Model marker pinl coloring to stand out. [image: image] <https://user-images.githubusercontent.com/5296507/66130814-5d1a5880-e5c0-11e9-9dc6-78aad0a49bd5.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1140?email_source=notifications&email_token=AA6JY4DVRPNM6YAH6FRUKXDQMXXZLA5CNFSM4I35TVY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAIGVDI#issuecomment-537946765>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6JY4AB5J56IPY2ZPJ4DATQMXXZLANCNFSM4I35TVYQ> .

[jimmyDunne]

I don't build the GUI locally so if you could force another CI build I can get the artifact?

[aymanhab]

Thanks @jimmyDunne Artifact of master is ready to test. Sorry about the confusion

[jimmyDunne]

Yep, looks great! Thanks, Ayman.