Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muscle wrapping visualization is incorrect when muscle loses contact with WrapCylinder #1111

Closed
tkuchida opened this issue May 2, 2019 · 7 comments
Closed

Muscle wrapping visualization is incorrect when muscle loses contact with WrapCylinder #1111

tkuchida opened this issue May 2, 2019 · 7 comments
Labels
bug Visualization
Milestone
OpenSim 4.1

Comments

@tkuchida
Copy link
Member

tkuchida commented May 2, 2019

Steps to reproduce

  • open Rajagopal2015 model
  • change knee_angle_r to 30 degrees

Expected result

Gastroc path looks reasonable.

Actual result

Path seems to be computed correctly:

Environment and GUI version

Public release of 4.0
@jenhicks
Copy link
Member

jenhicks commented Sep 4, 2019

@aymanhab will investigate, given recent discussion on forum.

@aymanhab
Copy link
Member

I'm working on a fix now,

@aymanhab aymanhab mentioned this issue Sep 13, 2019
Merged
@aymanhab
Copy link
Member

Let me clarify the scope of the issue:

  • This has no effect whatsoever on computation or correctness of results, pure visualization issue.
  • All models display correctly on loading regardless of wrapping. If wrong display happens save the model in this bad configuration and load it and it will be fine.
  • Only models/muscles that could be affected are those with multiple wrap objects when an object switches from engaged to disengaged while some other objects are engaged either during a motion playback or while moving a coordinate slider.

aymanhab added a commit that referenced this issue Sep 26, 2019
@aymanhab
Fix issues #2569 (Moving pathpoint not handled properly if appears fi…
b7ffff5 
…rst in path), #1111 (mishandling of multiple wrap objects on same muscle when some of them disengage)
@jenhicks
Copy link
Member

@jimmyDunne Can you test this one?

@jimmyDunne
Copy link
Member

Placing the model in the affected pose, saving, and reloading;

image

@aymanhab
Copy link
Member

aymanhab commented Oct 3, 2019 via email

@jimmyDunne
Copy link
Member

I am on Mac. I used the OpenSim-fix_visualization_multiple_wraps artifact

aymanhab added a commit that referenced this issue Oct 17, 2019
@aymanhab
Fix place where pathpoints are shown when not engaged. (#1134)
d3058e6 
* When updating visuals due to edit, make sure Frames are marked as visible in ModelDisplayHints so they're not skipped over by the Geometry classes in opensim-core

* Change place where intermediate pathpoints are shown when wrapping is not engaged.

* Keep track of number of engaged wraps for detailed analysis on update.

* Detect wrap change scenario

* Squashed commit of the following:

commit 97dd524
Author: jimmyDunne <james.dunne@stanford.edu>
Date:   Wed Sep 18 11:44:11 2019 -0400

    Update Confluence URLS for 4.1 (#1135)

    * https for confluence URLs

    * remove port number

    * /OpenSim40/ -> OpenSim

    * Revert "remove port number"

    This reverts commit af94f83.

    * Revert "/OpenSim40/ -> OpenSim"

    This reverts commit a3a97eb.

    * remove port number

    * Update commit on opensim-visualizer submodule to use 4.1

commit e1a85ee
Author: Ayman Habib <ahabib@stanford.edu>
Date:   Wed Sep 18 08:43:25 2019 -0700

    Update splash screen to version 4.1 (#1136)

    * Update splash screen to 4.1

    * Fix URL in About Panel

* Cache wrapCount for multi-wrap case on update

* Keep track of actual engaged wrapPoints for use in updatePathWithWrapping

* Management of multiple wrap objects that may arbitrarily disengage, code is triggered only when wrap disengages and multiple wraps exist

* Fix issues #2569 (Moving pathpoint not handled properly if appears first in path), #1111 (mishandling of multiple wrap objects on same muscle when some of them disengage)

* Update CHANGELOG.md

Update changelog to reflect bug-fixes

* Restore number of points per muscle wrap (small number was useful for debugging)
@jenhicks jenhicks added this to the OpenSim 4.1 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Visualization
Projects
None yet
Milestone
OpenSim 4.1
Development

No branches or pull requests
4 participants
@aymanhab @tkuchida @jenhicks @jimmyDunne